Revise documentation of Interval operations
#3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
force-pushed
the
schillic/docs_interval
branch
from
bfbb218
to
0585900
Compare
mforets
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
removing docs for methods which are already documented somewhere else (for another set type or in some default), makes sense to me.
the cases for which it would a be a pity to remove are those that have an algorithmic description or a non-obvious input / output. but for those cases we can always keep the previous doc as code comment.
Yes, agreed. I think I always kept algorithm and other notes in this PR unless they were trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.