fix #17: attribute interpolation bug

JuliaPluto · Oct 23, 2021 · 3430979 · 3430979 · clarkevans · Oct 23, 2021
1 parent 067eb48
commit 3430979
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # Release Notes
 
+## v0.9.2
+
+- Fix #17: Attribute interpolation bug
+
 ## v0.9.1
 
 - Fix #16: Error interpolating unicode into JS

diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "HypertextLiteral"
 uuid = "ac1192a8-f4b3-4bfe-ba22-af5b92cd3ab2"
 authors = ["Clark C. Evans <[email protected]>"]
-version = "0.9.1"
+version = "0.9.2"
 
 [compat]
 julia = "1"

diff --git a/docs/src/attribute.md b/docs/src/attribute.md
@@ -355,3 +355,9 @@ exclude it to guard it against accidently forgetting a comma.
     ERROR: LoadError: DomainError with data_value = 42:
     assignments are not permitted in an interpolation⋮
     =#
+
+Interpolation of adjacent values should work.
+
+    x = 'X'; y = 'Y';
+    @htl("<span att='$x$y'/>")
+    #-> <span att='XY'/>
diff --git a/src/lexer.jl b/src/lexer.jl
@@ -82,8 +82,6 @@ function interpolate(args)
                   "interpolation is limited to a single component"))
             elseif state == STATE_ATTRIBUTE_VALUE_SINGLE_QUOTED ||
                    state == STATE_ATTRIBUTE_VALUE_DOUBLE_QUOTED
-                @assert parts[end] isa String
-                name = parts[end][attribute_start:attribute_end]
                 push!(parts, :(attribute_value($(esc(input)))))
             elseif state == STATE_BEFORE_ATTRIBUTE_NAME ||
                    state == STATE_AFTER_ATTRIBUTE_NAME