Add streaming API #463
Draft
Add streaming API #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
force-pushed
the
jps/stream2
branch
from
c32db49
to
8eb1a6a
Compare
|
Am I correct in thinking that all the necessary items except for tests are complete? |
|
Generally yes, I think we're pretty close to this being merge-ready. There are some remaining TODOs that I need to finish, but most are reasonably small. I could definitely use help with writing tests - just validating that we can run various kinds of pipelines and that they work across multiple workers would be really useful. |
Merged
JamesWrigley
force-pushed
the
jps/stream2
branch
from
1c4473b
to
21217ab
Compare
JamesWrigley
force-pushed
the
jps/stream2
branch
2 times, most recently
from
ed89a7f
to
3274093
Compare
JamesWrigley
force-pushed
the
jps/stream2
branch
from
3274093
to
4013384
Compare
JamesWrigley
force-pushed
the
jps/stream2
branch
from
9f0ac3f
to
96bad48
Compare
Instead of taking/putting values sequentially (which may block), runs "pull" and "push" tasks for each input and output, respectively. Uses buffers to communicate values between pullers/pushers and the streaming task, instead of only using one buffer per task-to-task connection.
Switch from RemoteFetcher to RemoteChannelFetcher
Pass object rather than type to `stream_{push,pull}_values!`
ProcessRingBuffer: Don't exit on graceful interrupt when non-empty
JamesWrigley
force-pushed
the
jps/stream2
branch
from
96bad48
to
b3b70e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
spawn_streamingtask queue to transform tasks into continuously-executing equivalents that automatically take from inputs streams/channels and put their result to an output stream/channel. Useful for processing tons of individual elements of some large (or infinite) collection.Todo:
StreamobjectStreamfinish_stream(xyz; return=abc)to return custom value (elsenothing)mmap?)waitany-style input stream, taking inputs from multiple taskstake!from input streams concurrently, andwaitallon them before continuingput!into output streams concurrently, andwaitallon them before continuing