Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart deprecation cycle #128

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Restart deprecation cycle #128

merged 2 commits into from
Apr 11, 2020

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Apr 10, 2020

I appreciate if you can review this PR where I've cleaned up deprecated.jl for a next minor release as discussed in #126 .

After this is merged, we can consider triggering JuliaRegistrator as the version is already bumped in Project.toml.

@juliohm juliohm requested review from oxinabox and joshday April 10, 2020 14:37
@joshday
Copy link
Member

joshday commented Apr 10, 2020

How about deleting the file?

@juliohm
Copy link
Member Author

juliohm commented Apr 11, 2020

Makes sense. Will update the PR tomorrow 👍

@juliohm juliohm merged commit 71041fb into master Apr 11, 2020
@juliohm juliohm deleted the depwarn branch April 11, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants