Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade BLISBLAS.jl #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amontoison
Copy link

@carstenbauer
I compiled an LP64 version of BLIS with Yggdrasil.
With Julia 1.9, we should be able to combine them with LAPACK_jll and LAPACK32_jll.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (b6764e5) to head (db7ad21).
Report is 7 commits behind head on main.

Files Patch % Lines
src/BLISBLAS.jl 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #6       +/-   ##
==========================================
- Coverage   91.66%   0.00%   -91.67%     
==========================================
  Files           1       1               
  Lines          12      20        +8     
==========================================
- Hits           11       0       -11     
- Misses          1      20       +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison
Copy link
Author

amontoison commented Jun 8, 2024

@carstenbauer
I updated this PR because some users wanted to try it in Ipopt.jl. Here are a few key points:

  • LBT requires at least Julia 1.9 to work on all platforms.
  • BLIS serves only as an alternative to BLAS. Therefore, it must be combined with LAPACK to provide a full alternative to OpenBLAS.
  • For many packages compiled with Yggdrasil, we need an LP64 BLAS/LAPACK compiled with 32-bit integers. This PR includes both LP64 and ILP64 versions, enabling functionality similar to MKL.jl or AppleAccelerate.jl.
  • OpenBLAS is no longer necessary as we can now utilize LAPACK routines that rely on BLIS.

@amontoison amontoison changed the title Add blis32_jll Upgrade BLISBLAS.jl Jun 8, 2024
@carstenbauer
Copy link
Member

Haven't reviewed this yet but note that almost all CI runs are failing. Can you address those failures first?

@amontoison
Copy link
Author

Haven't reviewed this yet but note that almost all CI runs are failing. Can you address those failures first?

The issues seem related to blis. Since the OpenBLAS backend wasn't cleared, blis symbols were never used.
I opened PR #18 to verify it.

It turns out that using BLISBLAS.jl didn't change the default BLAS backend before this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants