Make DefaultStable and DefaultUnstable dispatchable and display without internals #56661
+50
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
DEFAULT_STABLE
was a giant chain of algorithms reflecting the full sorting dispatch system. Now, it's simplyDefaultStable()
. This has a few minor impacts:Previously, the public binding
Base.Sort.DEFAULT_STABLE
documented non-public implementation details of sorting dispatch in its extended help with a caviat that they are internal. Now,Base.Sort.DEFAULT_STABLE
refers to the non-public bindingBase.Sort.DefaultStable
and implementation details are documented there with a warning that they are non-public.Previously, dispatching on
Base.Sort.DEFAULT_STABLE
required writing::typeof(Base.Sort.DEFAULT_STABLE)
whereas now one could alternatively dispatch on the (internal) typeBase.Sort.DefaultStable
.Previously
Base.Sort.DEFAULT_STABLE === Base.Sort.DEFAULT_UNSTABLE
so when writing sorting algorithms for custom collections it was impossible to determine if the user asked for a stable algorithm. NowDEFAULT_STABLE
isDefaultStable()
andDEFAULT_UNSTABLE
isDefaultUnstable()
. Both the algorithms expand to the same large chain of algorithms_DEFAULT_ALGORITHMS_FOR_VECTORS
but it is possible to intercept them before that happens.Base.Sort.DEFAULT_STABLE
now prints asDefaultStable()
instead ofFactored out of #54494 at Triage's request (the git history reflects this history).