-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
precompilepkgs: make the circular dep warning clearer and more informative #56621
precompilepkgs: make the circular dep warning clearer and more informative #56621
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
We should probably backport to 1.10 too, since we expect that users will be hitting extension cycles a lot more often on that release. In 1.11 these cycles are supposed to be impossible, except for environment tearing (where you end up with a package graph that doesn't actually Still very good to have (esp. on 1.10), just want to be clear about whether this is a "normal" error any more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I think it's much clearer to users what's going on here now.
Thanks for iterating on this @IanButterworth
Oh the cycle order does look a bit "backwards" to me I would have expected the dependency of a package to be above it, not below |
I think of it the other way. Matching the sentence order for "Foo depends on Bar, which depends on Baz"
|
Hmm.. What if we reverse the indentation from greatest to smallest?
Does that align our intuitions? |
e39c153
to
56cf730
Compare
Co-Authored-By: Cody Tapscott <[email protected]>
This reverts commit 2746082.
This is an important optimization for us not to lose, since we scan the deps graph very redundantly.
Co-authored-by: Cody Tapscott <[email protected]>
56cf730
to
d84aef1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still find the staircase weird here (and my first instinct is to read it "backwards"), but this is a big improvement and all the functionality looks ship-shape to me
Good to merge, I think!
Yeah, lets see what people make of it and tweak if there's concensus |
Was e.g.
Now
Thanks to @topolarity figuring out proper cycles tracking.