Skip to content

Commit

Permalink
AbstractIntepreter: revert invokecall to a positional argument (#50763
Browse files Browse the repository at this point in the history
)

In #50739, `invokecall` argument of `concrete_eval_call` was changed to
a keyword argument. However, this was an unintentional change that
imposes unnecessary changes to be required on packages using external
`AbstractInterpreter`. This commit simply restores it to positional
argument as before.
  • Loading branch information
aviatesk authored Aug 2, 2023
1 parent 3eddd17 commit d64d336
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions base/compiler/abstractinterpretation.jl
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ function abstract_call_method_with_const_args(interp::AbstractInterpreter,
end
eligibility = concrete_eval_eligible(interp, f, result, arginfo, sv)
if eligibility === :concrete_eval
return concrete_eval_call(interp, f, result, arginfo, sv; invokecall)
return concrete_eval_call(interp, f, result, arginfo, sv, invokecall)
end
mi = maybe_get_const_prop_profitable(interp, result, f, arginfo, si, match, sv)
mi === nothing && return nothing
Expand Down Expand Up @@ -881,7 +881,7 @@ function collect_const_args(argtypes::Vector{Any}, start::Int)
end

function concrete_eval_call(interp::AbstractInterpreter,
@nospecialize(f), result::MethodCallResult, arginfo::ArgInfo, sv::AbsIntState;
@nospecialize(f), result::MethodCallResult, arginfo::ArgInfo, sv::AbsIntState,
invokecall::Union{InvokeCall,Nothing}=nothing)
args = collect_const_args(arginfo, #=start=#2)
if invokecall !== nothing
Expand Down

0 comments on commit d64d336

Please sign in to comment.