Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing precompilation problems in Julia 1.10.0 #277

Merged
merged 24 commits into from
Jan 10, 2024

Conversation

cncastillo
Copy link
Member

This pull request is meant to fix:

@cncastillo cncastillo linked an issue Dec 27, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c23fa8a) 87.91% compared to head (7ab69e2) 92.60%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   87.91%   92.60%   +4.68%     
==========================================
  Files          33       33              
  Lines        2251     2245       -6     
==========================================
+ Hits         1979     2079     +100     
+ Misses        272      166     -106     
Flag Coverage Δ
base 92.67% <ø> (+6.37%) ⬆️
core 90.47% <ø> (+8.98%) ⬆️
files 92.34% <ø> (+6.28%) ⬆️
komamri 93.89% <ø> (+0.01%) ⬆️
plots 93.28% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
KomaMRIBase/src/KomaMRIBase.jl 100.00% <ø> (ø)
KomaMRIBase/src/timing/KeyValuesCalculation.jl 84.72% <ø> (+7.50%) ⬆️
KomaMRIPlots/src/KomaMRIPlots.jl 100.00% <ø> (ø)
src/KomaMRI.jl 100.00% <ø> (ø)

... and 9 files with indirect coverage changes

@beorostica
Copy link
Contributor

I cannot reproduce the problem on my Windows machine. So, I forked KomaMRI with my account to test the CI without altering this repository. By forcing the Kaleido_jll version to 0.1, as done in the tests of PlutoPlotly (refer to this for more details), the tests of KomaMRIPlots are successful (refer to https://github.com/beorostica/KomaMRI.jl/pull/1 and beorostica@b6e2788).

It appears that the issue lies with Kaleido_jll in Windows and Julia 1.9.4 and 1.10.0.

@cncastillo
Copy link
Member Author

cncastillo commented Dec 28, 2023

They only forced Kaleido 0.1 for the tests, not for the package, so I am not sure if the package will be installable in Windows.

I think that Kaleido 0.2 added support for Apple silicon, not sure I want to lose that (https://github.com/plotly/Kaleido/releases).

@cncastillo cncastillo linked an issue Jan 4, 2024 that may be closed by this pull request
@beorostica beorostica merged commit 000b115 into master Jan 10, 2024
16 checks passed
@beorostica beorostica deleted the fixing-precompilation-julia-1.10 branch January 10, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants