-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing precompilation problems in Julia 1.10.0 #277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 87.91% 92.60% +4.68%
==========================================
Files 33 33
Lines 2251 2245 -6
==========================================
+ Hits 1979 2079 +100
+ Misses 272 166 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I cannot reproduce the problem on my Windows machine. So, I forked KomaMRI with my account to test the CI without altering this repository. By forcing the Kaleido_jll version to 0.1, as done in the tests of PlutoPlotly (refer to this for more details), the tests of KomaMRIPlots are successful (refer to https://github.com/beorostica/KomaMRI.jl/pull/1 and beorostica@b6e2788). It appears that the issue lies with Kaleido_jll in Windows and Julia 1.9.4 and 1.10.0. |
They only forced Kaleido 0.1 for the tests, not for the package, so I am not sure if the package will be installable in Windows. I think that Kaleido 0.2 added support for Apple silicon, not sure I want to lose that (https://github.com/plotly/Kaleido/releases). |
Changed message.
This pull request is meant to fix: