-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overloaded_inputs for preparations #672
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 112 114 +2
Lines 5609 5619 +10
=======================================
+ Hits 5475 5485 +10
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CI failures seem not related. |
Thanks for getting this started! In terms of design, I think we should not just return an |
All tests passed now. |
Also implemented the |
Fix: #668
This PR only adds the
overloaded_inputs
functionalities for Jacobian preparations, not sure if the derivative, gradient and hessian preparation need this API.The tests for this feature maybe too simple, need some suggestions for better test cases.