Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more 0.6 fixes #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some more 0.6 fixes #34

wants to merge 2 commits into from

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented May 26, 2017

Not sure about the ambiguity fix, tagging the doc to mv! is quite coarse. For reference, the error was:

MethodError:

mv!(
    ::Char,
    ::Float32,
    ::CUSPARSE.CudaSparseMatrixCSR{Float32},
    ::CUDArt.CudaArray{Float32,1},
    ::Float32,
    ::CUDArt.CudaArray{Float32,1},
    ::Char)
is ambiguous. Candidates:

mv!(
    transa::Char,
    alpha::Union{Complex{Float32}, Complex{Float64}, Float32, Float64}
    A::Union{CUSPARSE.CudaSparseMatrixBSR{T}, CUSPARSE.CudaSparseMatrixCSC{T}, CUSPARSE.CudaSparseMatrixCSR{T}, CUSPARSE.CudaSparseMatrixHYB{T}} where T
    X::CUDArt.CudaArray{T,1} where T, beta::Union{Complex{Float32}, Complex{Float64}, Float32, Float64}
    Y::CUDArt.CudaArray{T,1} where T
    index::Char)
in CUSPARSE at /home/tbesard/Projects/Julia-CUDA/CUSPARSE/src/sparse.jl:686

mv!(
    transa::Char,
    alpha::Float32
    A::Union{CUSPARSE.CudaSparseMatrixCSR{Float32}, Hermitian{Float32,CUSPARSE.CudaSparseMatrixCSR{Float32}}, Symmetric{Float32,CUSPARSE.CudaSparseMatrixCSR{Float32}}}
    X::CUDArt.CudaArray{Float32,1}, beta::Float32
    Y::CUDArt.CudaArray{Float32,1}
    index::Char)
in CUSPARSE at /home/tbesard/Projects/Julia-CUDA/CUSPARSE/src/sparse.jl:738

Possible fix, define
  mv!(::Char, ::Float32, ::CUSPARSE.CudaSparseMatrixCSR{Float32}, ::CUDArt.CudaArray{Float32,1}, ::Float32, ::CUDArt.CudaArray{Float32,1}, ::Char)

@codecov-io
Copy link

codecov-io commented May 26, 2017

Codecov Report

Merging #34 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   84.97%   85.22%   +0.24%     
==========================================
  Files           5        5              
  Lines        1145     1144       -1     
==========================================
+ Hits          973      975       +2     
+ Misses        172      169       -3
Impacted Files Coverage Δ
src/sparse.jl 88.82% <ø> (+0.08%) ⬆️
src/util.jl 71% <100%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef452a...f1f3f34. Read the comment docs.

@maleadt
Copy link
Contributor Author

maleadt commented May 26, 2017

OK, so the same ambiguity hits with other methods (incl mm!). Will need a proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants