-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize noise models #16
Conversation
f3aecd2
to
cf05dd9
Compare
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 93.68% 93.83% +0.15%
==========================================
Files 5 5
Lines 665 665
==========================================
+ Hits 623 624 +1
+ Misses 42 41 -1
Continue to review full report at Codecov.
|
ed95869
to
d9c9852
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need some clarification, maybe in the docstrings / ReadTheDocs as well. Not sure if the new functionality is otherwise understandable for the user.
08fb02e
to
9db0829
Compare
575fedf
to
6e46c65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for now because the remaining tests are tackled in other issues.
Extracted commits from #12 that relevant for generalization over independent variable distributions.
Also closes some coverage gaps.