Add support for Steam IM input methods #437
Open
+103
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K900
reviewed
Oct 30, 2024
pkgs/steam-im-modules/default.nix
Outdated
|
|
||
| nativeBuildInputs = [ | ||
| extra-cmake-modules | ||
| wrapGAppsHook3 |
There was a problem hiding this comment.
I don't think any of the hooks should be necessary, given it's just a library.
There was a problem hiding this comment.
Yes, you are right. I should check docs first. I'll remove them later.
|
Big thanks for doing this! I was hoping someone with actual CJK IME experience would come around and help us here eventually, and you did. I left one somewhat nitpicky comment and I'll look at the code a bit closer later. |
samueldr
added
1. type: bug
Signed-off-by: bigsaltyfishes <[email protected]>
bigsaltyfishes
force-pushed
the
pr/steam-im
branch
from
00442c1
to
7f254c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #364
Add support for Chinese Pinyin, Japanese, Korean input methods.
As for Traditional Chinese input methods,
ibus-engines.table-chineseinnixpkgsnot working properly, so not adding support for it in this PR (SteamOS is using patched/updated version of it)