Make request throttle configurable #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was about to submit a similar pull request when I saw yours. We had to modify the library to set the requestsPerSecond parameter to 1 to avoid intermittent turk throttling problems. Set at 1 it seems reliable. |
|
1 request per second? That just seems astonishingly low, when trying really move any amount of data. The default of 3 was working ok for me, but i was wanting to bump it up to 5 or 6... |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:ejs:20161128 - https://snyk.io/vuln/npm:ejs:20161130 - https://snyk.io/vuln/npm:ejs:20161130-1 Latest report for hendrikschneider/mturk-api: https://snyk.io/test/github/hendrikschneider/mturk-api
[Snyk] Fix for 3 vulnerable dependency paths
updated dependices with snyk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the 3 requests per second to be a bit limiting, so I put that constant on an environment variable.
I thought about moving the queue instantiation into the client constructor, and reading the limit from the
configobject as a different solution.Also, does anyone know at what threshold you will begin to get 503's from mturk?