Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): mention that pnpm zip will erase dist-zip #805

Closed
wants to merge 1 commit into from
Closed

docs(readme): mention that pnpm zip will erase dist-zip #805

wants to merge 1 commit into from

Conversation

dandv
Copy link
Contributor

@dandv dandv commented Dec 9, 2024

Priority*

  • High: This PR needs to be merged first, before other tasks.
  • Medium: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

Submitting this PR after I renamed extension.zip to something else and ran pnpm zip again... only to find out that my renamed extension was gone :)

@dandv dandv requested a review from Jonghakseo as a code owner December 9, 2024 12:40
@Jonghakseo Jonghakseo mentioned this pull request Dec 11, 2024
Merged
3 tasks
@Jonghakseo
Copy link
Owner

I think we can replace it with the above PR.

@Jonghakseo
Copy link
Owner

As the above PR is merged, no modifications to the README.md are required, so I'm closing this PR. Thank you for your contribution.

@Jonghakseo Jonghakseo closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonghakseo Jonghakseo Awaiting requested review from Jonghakseo Jonghakseo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandv @Jonghakseo