feat: add session storage access levels, live update across instances + TSDocs IntelliSense for guidance #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…rough type guards and stay DRY
|
Found some time 🐌🐌 Cross-Page Live UpdateLive Update across all extension instances are now available, leading to the theme value to update in real-time. Removed ts-ignore commentsFactored out your
|
D1no
changed the title
Jonghakseo
approved these changes
Dec 2, 2023
|
@all-contributors please add @D1no for code |
|
I've put up a pull request to add @D1no! 🎉 |
|
Thank you 🥰 feel free to ship it or let me k ow what I should change ❤️ love intercontinental collaboration |
jguddas
approved these changes
Dec 7, 2023
aspiers
pushed a commit
to rolod0x/rolod0x
that referenced
this pull request
Jan 28, 2024
live update across instances + TSDocs IntelliSense for guidance Cherry-picked from c580f70 Jonghakseo/chrome-extension-boilerplate-react-vite@c580f70 See Jonghakseo/chrome-extension-boilerplate-react-vite#308 Co-authored-by: JongHak Seo <[email protected]>
aspiers
pushed a commit
to rolod0x/rolod0x
that referenced
this pull request
Jan 28, 2024
live update across instances + TSDocs IntelliSense for guidance Cherry-picked from c580f70 Jonghakseo/chrome-extension-boilerplate-react-vite@c580f70 See Jonghakseo/chrome-extension-boilerplate-react-vite#308 Co-authored-by: JongHak Seo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi thank you for maintaining this boilerplate :)
Session Storage Area and Access Levels
I've noticed that
StorageType.Sessionwasn't able to be fully utilized, since they need an extra access-level step in chrome to allow content scripts to also access that storage area. A functionality that is pretty important for background workers processing page content.So I have added that functionality after noticing.
In-Code Guidance via TSDocs
Also, since the whole browser extension landscape is rather confusing for most people, I have added brief TSDocs to the
createStorageinterface and proximal types to provide in editor guidance:Cross-Page Live Update
Originally I wanted to extend your creatStorage solution with an aditional
liveUpdateflag to be able to keep its many instances (content, popup, side panel, etc) synchronized through properly invalidating the cache withonChangedlisteners... but I ran out of time for now.In its current form, the storage and hooks only get pulled once a page starts... kinda omitting the big advantage of using the storage for keeping state in sync. Like when you change the color of your
theme, you probably want that to be applied everywhere directly and not have to open and close pages.Maybe I can do that at another time. All the best from Berlin!
Note:
Heads up: I am not sure how serious the firefox support in a chrome extension boilerplate is, but session storage areas are very differently handled by firefox. See here: chrome.storage.session in firefox