-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Modify to let the plugin do the build completion detection not file system. #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works better, but after rebuild is done, the plugin don't be displaying properly.
THIS HAPPENED ONLY WHEN I'M ADD CODE
I must reopen it manually and then it works, error from #184 don't ocurr, but it's the same case, i must click outside and after that, open again manually and then i can see my changes.
PS: I see also error like this on reload:
THIS HAPPENED ONLY WHEN I'M DELETE CODE
The entire script is stoped on that error.
Intresting thing is, when i have this small window, from first screen, the code reload is working well, i can remove or add a hundreds line of code, and nothing break, cause plugin don't need to be reloaded, cause it's break already.
If i refresh it manually/reopen, it break again following cases from above
@Jonghakseo And the question, we need to create this warn? IMO it's a little annoying, if i see i had an error, but in real i don't have, it's only information, clearing it don't work, cause after clean, we use it again, and after each socket disconnect this warn goes into this console. |
@PatrykKuniczak |
In my case, the problem was intermittently clearing files while waiting for a build of an existing file. I've modified the options, can you give it another try? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfect <3
Fixed #184