Use vitest #260
Use vitest #260
Conversation
.all-contributorsrc
Outdated
There was a problem hiding this comment.
I think good idea is disable prettier for this file, cause this bot add new contributor to this file automattically and don't reformat like prettier.
README.md
Outdated
There was a problem hiding this comment.
IMO the previouse version is better, cause have short and clear links, paste entire message as a link, isn't good idea.
Create here only the things related to your feature :)
src/pages/devtools/index.html
Outdated
There was a problem hiding this comment.
i think it's bug with prettier, but i think why you run prettier for entire project, i was configure lint-staged, for run prettier and eslint only for staged file.
package.json
Outdated
| "@types/node": "20.8.10", | ||
| "@types/react": "18.2.35", | ||
| "@types/react-dom": "18.2.14", | ||
| "@types/ws": "8.5.8", | ||
| "@typescript-eslint/eslint-plugin": "6.9.1", | ||
| "@typescript-eslint/parser": "6.9.1", | ||
| "@vitejs/plugin-react": "2.2.0", | ||
| "@vitejs/plugin-react": "4.1.1", |
There was a problem hiding this comment.
You can't update this read more in #258 (comment)
package.json
Outdated
| "ts-loader": "9.5.0", | ||
| "tslib": "2.6.2", | ||
| "typescript": "5.2.2", | ||
| "vite": "3.2.7", | ||
| "vite": "4.5.0", |
There was a problem hiding this comment.
You can't update this read more in #258 (comment)
package.json
Outdated
| "ts-loader": "9.5.0", | ||
| "tslib": "2.6.2", | ||
| "typescript": "5.2.2", | ||
| "vite": "3.2.7", | ||
| "vite": "4.5.0", | ||
| "vitest": "^0.34.6", |
There was a problem hiding this comment.
I think the good approach is don't use '^' anyway, but here we have deps bot, and they are looking for new versions, as you can see in other packages we don't have it, but here @Jonghakseo could say more if he want this, let's do it :)
package.json
Outdated
| @@ -56,18 +55,17 @@ | |||
| "eslint-plugin-react-hooks": "4.6.0", | |||
| "fs-extra": "11.1.1", | |||
| "husky": "8.0.3", | |||
| "jest": "29.7.0", | |||
| "jest-environment-jsdom": "29.7.0", | |||
| "jsdom": "^22.1.0", | |||
There was a problem hiding this comment.
I think the good approach is don't use '^' anyway, but here we have deps bot, and they are looking for new versions, as you can see in other packages we don't have it, but here @Jonghakseo could say more if he want this, let's do it :)
|
@wonkyDD Don't panic 😁 Let's open new one or reopen that, if you working on that, you can convert it to draft |
|
@PatrykKuniczak
To use vitest successfully, we need to upgrade However, after reading the issue you linked to, I realized that I am not able to update it at this time. As you said, I think we should also hold off on using vitest until the issue is resolved or Thanks a lot. |
|
@wonkyDD You don't disturb me 😁 I was thinking about workaround, i can equal the source of the file, but there's performance on larger files could be sick. If i have more time on this month, i can try to solve the PR on rollup, then they can relase new version, and then we can pull this and update, as you can see, everything is blocked 😆 |
No description provided.