Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/ Update packages #251

Merged
merged 2 commits into from
Nov 5, 2023
Merged

chore/ Update packages #251

merged 2 commits into from
Nov 5, 2023

Conversation

PatrykKuniczak
Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak commented Nov 5, 2023

#233
I update all packages, but i can't bum vite and @vitejs/plugin-react to latest version, cause on v4 vite don't send to us dir path name of css files, heres the link to issues:

vitejs/vite#12072
rollup/rollup#4724

And without that assetFileNames in vite.config.js don't work properly, and there's not workaround to have that path name, maybe we can try to equal the assetInfo.source to the file source, but it's not optimal, cause the performance on larger file could be bad.

Now we can bundle it into 1 css, but for extenstion it's not work, cause we need separete files for each script.

We can merge this and wait, for this feature on v4, and then we can bump also this, or maybe somebody have workaround for that, then we can use it and bump vite to latest 4.5.0

@PatrykKuniczak PatrykKuniczak self-assigned this Nov 5, 2023
@PatrykKuniczak PatrykKuniczak added the enhancement New feature or request label Nov 5, 2023
@PatrykKuniczak
Copy link
Collaborator Author

@Jonghakseo It's ready for merge, or no.

You tested it already?

Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it under normal development conditions and it seems to be working.
That took some time.

LGTM

@PatrykKuniczak PatrykKuniczak merged commit abe4ebf into main Nov 5, 2023
4 checks passed
@PatrykKuniczak PatrykKuniczak deleted the chore/update-packages-#233 branch November 5, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants