Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add use case other modules in content script #246

Merged
merged 5 commits into from
Nov 5, 2023

Conversation

Jonghakseo
Copy link
Owner

@Jonghakseo Jonghakseo commented Nov 5, 2023

There is an issue with using import in content/index.ts due to module unsupport in the Chrome extension. As a workaround, We can manage dependencies inside other modules that use import(). However, this is not visible in the code, making it difficult for users to recognize, so I've added a use case.

Other changes

  • Cleaned up dynamic import plugin code

@Jonghakseo Jonghakseo changed the title Fix: Use other modules in content script via import Fix: Add use case other modules in content script Nov 5, 2023
@Jonghakseo Jonghakseo marked this pull request as ready for review November 5, 2023 09:53
@PatrykKuniczak
Copy link
Collaborator

@Jonghakseo That's interesting workaround, if i want to run func under condition, i can use this import inside if statement, then this self invoked func is used from e.g 'injected' run when i want it

@Jonghakseo Jonghakseo merged commit f622df9 into main Nov 5, 2023
4 checks passed
@Jonghakseo Jonghakseo deleted the fix/use-another-modules-in-content-script branch November 5, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants