Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more pythonic logging #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rknLA
Copy link

@rknLA rknLA commented May 2, 2016

I went ahead and changed up the logging here to use Python's built-in logging module, rather than redirecting stdin and stdout. While this might seem pedantic, the main reason I had to do this was because redirecting stdout makes pdb effectively useless, making it impossible to debug what's going on with the issue I've mentioned in #2.

At this point, I'm still trying to pinpoint where things are going wrong, but I thought this might be helpful to merge back into your branch.

I'm happy to remove the added log messages as well, if you prefer.

@rknLA rknLA force-pushed the rkn-debugging branch from 508859d to 5109e9e Compare May 2, 2016 16:07
@JonathanTaquet
Copy link
Owner

JonathanTaquet commented May 12, 2016

Thank you for your work.

I have comments/questions:

  • Is it possible and simple to show your log messages only in a verbose mode?
  • The reason why I used such logging method was for executable releases (not launched from a terminal). With the logging module some messages (like the ones coming from pyaudio errors when reading samples with too high sampling frequency) are lost. Is it possible to intercept them efficiently (maybe using stdout/stderr redirection to logging)?

@JonathanTaquet JonathanTaquet force-pushed the master branch 2 times, most recently from 5318017 to 0fcba53 Compare March 13, 2017 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants