Ensure that the chef shutdown service is configurable #2

JonathanSerafini · 2016-12-22T19:44:25Z

New attributes in attributes/cfn-shutdown.rb

# Name of the node which should be deleted when the service executes
#
# This option supports the following values:
# - DETECT_CLIENTNAME: grep the node_name from /etc/chef/client.rb
# - DETECT_NODENAME: node.name
# - DETECT_HOSTNAME: hostname --fqdn
# - *: Any other value is considered as the node_name you wish to delete
#
# @since 2.2.0
default['cfn']['shutdown']['node_name'] = 'DETECT_NODENAME'

Pull request to resolve issue in #1
@webframp @sandervanburken Would this change work for you ?

webframp · 2016-12-22T20:59:13Z

templates/default/shutdown/chef_lifecycle.erb

+  ;;
+  stop)
+    echo "***** Deleting node and client *****"
+    node_name="<%= @node_name %>"


Is this expected to be the value of the attribute?

webframp · 2016-12-22T21:00:26Z

recipes/shutdown.rb

@@ -1,6 +1,7 @@
 # Ensure deletes the node and client upon shutdown
 #
-cookbook_file '/etc/init.d/chef_lifecycle' do
+template '/etc/init.d/chef_lifecycle' do
+  source 'shutdown/chef_lifecycle.erb'
  mode '0750'


Does this need a variables parameter to pass node['cfn']['shutdown']['node_name'] to the template as node_name ?

JonathanSerafini added 2 commits December 22, 2016 14:41

Ensure that the chef shutdown service is configurable

264485e

Restore default behavior for cfn-shutdown

59d18b3

webframp reviewed Dec 22, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure that the chef shutdown service is configurable #2

Ensure that the chef shutdown service is configurable #2

JonathanSerafini commented Dec 22, 2016

webframp Dec 22, 2016

webframp Dec 22, 2016

Ensure that the chef shutdown service is configurable #2

Are you sure you want to change the base?

Ensure that the chef shutdown service is configurable #2

Conversation

JonathanSerafini commented Dec 22, 2016

webframp Dec 22, 2016

Choose a reason for hiding this comment

webframp Dec 22, 2016

Choose a reason for hiding this comment