Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a signal handler for SIGUSR1 that forwards the signal to nginx telling it to reopen log files. This is necessary after rotating log files, for example. See https://nginx.org/en/docs/control.html#logs. Previously we did something like
but support for sending SIGUSR1 directly to the container is a bit nicer IMO.
This patch also adds a section on signal handling under "Advanced Usage" in the documentation.