Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow injecting root certificate validity via env and also validity for new certs, when using USE_LOCAL_CA=1 #229

Closed
wants to merge 1 commit into from

Conversation

chreniuc
Copy link

I added support for controlling the validity of the root certificate and the new certificates, when using local CA(discussion started here: #225).

I tried as you proposed, to generate a root certificate with a longer validity by changing the script and running it outside of the container. It worked to generate a root certificate with a validity bigger than 30 days. But when the container is running, it defaults to 30 days for new certificates, because it uses the script from the container, which has hardcoded 30 days in the openssl_cnf that is also used when generating a new certificate.

I also documented the newly added envs, ROOT_CERT_LOCAL_CA_VALIDITY and NEW_CERT_LOCAL_CA_VALIDITY.

@JonasAlfredsson
Copy link
Owner

Sorry for slow response, but I have finally have time to look at this.

I am not entirely sure I want to make it so easy and obvious to change this variable. Instead of forcing my ideas into this pull request I have created another one which I would love your feedback on: #230

@chreniuc
Copy link
Author

chreniuc commented Mar 1, 2024

Replaced by #230

@chreniuc chreniuc closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants