Test the nginx configuration before reloading. This avoids crashing t…

…he container if there are configuration errors.
JonasAlfredsson · Sep 22, 2023 · 339c1a4 · 339c1a4
1 parent 5052491
commit 339c1a4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/scripts/run_certbot.sh b/src/scripts/run_certbot.sh
@@ -169,5 +169,11 @@ done
 # did indeed get certificates for.
 auto_enable_configs
 
+# Make sure the Nginx configs are valid.
+if ! nginx -t; then
+  error "Nginx configuration is invalid, skipped reloading. Check the logs for details."
+  exit 0
+fi
+
 # Finally, tell Nginx to reload the configs.
 nginx -s reload
diff --git a/src/scripts/run_local_ca.sh b/src/scripts/run_local_ca.sh
@@ -247,5 +247,11 @@ done
 # did indeed succeed with.
 auto_enable_configs
 
+# Make sure the Nginx configs are valid.
+if ! nginx -t; then
+  error "Nginx configuration is invalid, skipped reloading. Check the logs for details."
+  exit 0
+fi
+
 # Finally, tell Nginx to reload the configs.
 nginx -s reload