doc: small install doc updates #1744
Conversation
| @@ -58,8 +58,7 @@ Then build and install a local copy of libsecp256k1 for python-bitcointx: | |||
| cd deps | |||
| git clone https://github.com/bitcoin-core/secp256k1.git | |||
| cd secp256k1 | |||
| git checkout v0.4.1 | |||
| make clean | |||
There was a problem hiding this comment.
remove make clean, it doesn't do anything
(also not mentioned in secp doc)
| @@ -58,8 +58,7 @@ Then build and install a local copy of libsecp256k1 for python-bitcointx: | |||
| cd deps | |||
| git clone https://github.com/bitcoin-core/secp256k1.git | |||
| cd secp256k1 | |||
| git checkout v0.4.1 | |||
| make clean | |||
| git checkout v0.5.0 | |||
There was a problem hiding this comment.
using v0.5.0 since May https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1701/files
docs/INSTALL.md
Outdated
| @@ -203,7 +201,7 @@ Once you have finished installing the program via one of the two above methods f | |||
| #### Configuring JoinMarket | |||
| Lastly we must configure JoinMarket to allow it to connect to Bitcoin Core. Refer to [this](USAGE.md#managing-your-joinmarket-data) section in the usage guide to generate a `joinmarket.cfg` file using `scripts/wallet-tool.py`. | |||
|
|
|||
| Edit your `joinmarket.cfg` file (at `~/.joinmarket` in Ubuntu if you used WSL, or in `C:\Users\<your username>\AppData\Roaming\joinmarket` if not) and replace the following lines in the section `[BLOCKCHAIN]` | |||
| Edit your `joinmarket.cfg` file (at `~/.joinmarket` in Ubuntu if you used WSL, or in `C:\Users\<your username>\AppData\Local\joinmarket` if not) and replace the following lines in the section `[BLOCKCHAIN]` | |||
There was a problem hiding this comment.
I don't use windows, but afaik this changed there recently: roaming -> local
There was a problem hiding this comment.
Depends on a Windows version I guess? On my Windows 10 laptop it's Roaming.
There was a problem hiding this comment.
yes probably win11,
at least I thought so but a more specific web search says otherwise :) https://www.makeuseof.com/tag/appdata-roaming-vs-local/
my bad, I dropped the change
| @@ -151,7 +150,6 @@ There are currently two choices for installing on Windows; one, directly install | |||
|
|
|||
| #### Installation directly on Windows | |||
|
|
|||
| As per the note above, binaries for JoinmarketQt are being offered with releases as of 0.7.0+. | |||
There was a problem hiding this comment.
removed this, as latest releases didn't have .exe
MarnixCroes
force-pushed
the
install-doc
branch
from
1e6c286 to
6de1bab
Compare
Small doc improvements/updates