Handle JsonRpcError
in _estimate_fee_basic
#1658
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_estimate_fee_basic
is supposed to returnNone
if fee rate can't be estimated and thenestimate_fee_per_kb
handles that with hardcoded fallback fee. ButJsonRpcError
wasn't handled and it could fail when fee estimation is not working in Core.Fixes #1653.
Previously it outputed unhandled error and hanged, now it's: