Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub CodeQL code scanning #1649

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

kristapsk
Copy link
Member

Add GitHub CodeQL code scanning.

#1648 was already found while testing it.

@kristapsk kristapsk changed the title Add CodeSQL code scanning Add GitHub CodeQL code scanning Feb 1, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@kristapsk
Copy link
Member Author

I would like to merge this sooner than later. We clearly lack manpower, so automating things and improving CI is the way to go, so that machines do more work for JoinMarket.

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK
not much downside, if any

@kristapsk
Copy link
Member Author

not much downside, if any

Only downside I can think of is extra CI minute. But that's nothing compared to other tests.

@kristapsk kristapsk merged commit 6b9a210 into JoinMarket-Org:master Feb 13, 2024
11 checks passed
@kristapsk kristapsk deleted the codeql branch February 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants