Rewrite AES code with cryptography (drop pyaes) #1526
Conversation
roshii
force-pushed
the
rewrite-aes
branch
2 times, most recently
from
8451e1f to
09cd05d
Compare
Vectors are parsed with parsed with https://gist.github.com/roshii/23f474394381093ba5ee814c1cb4fa6d |
I know about block ciphers, and about forward secrecy, but what is "forward block encryption"? I tried google but didn't see anything using that term? |
|
The CI failure appears unrelated. I have done a bit of testing moving wallets between old version of this encryption code and new version, checking for decryption (obviously) working, checking addresses and balances. It works. I've also read the code and see everything being correct. tACK 2ae5cca However I see no rush in merging this one, obviously. |
Sorry for that, I meant "block chaining" in which the output block is used as input block in the next round of encryption. Now that you mention forward secrecy I realize I did mix up terms having CBC schema in mind... |
OK, now the name is clear, I see what you're asking. Indeed we wouldn't need to check block by block (though, we could) that the actual CBC mechanism is working as intended (which seems to be the intention of the NIST vectors). But it'd be wrong to say it doesn't apply to our use case, since our plaintexts are bigger than a single CBC block, so block chaining is occurring. |
OK, I see my mistake now. I wrongly assumed that AES-CBC encryption of plaintext 2 was depending on plaintext 1 ... I now get that it is in fact plaintext block 2 that depends on plaintext block 1 |
|
|
|
rebased |
|
rebased |
d89dcde Remove convert_old_wallet.py script (Kristaps Kaupe) Pull request description: Old wallet format isn't used for years and script is broken since removal of pyaes dependency in #1526. If somebody still needs it, he can use older JoinMarket version to do conversion. Top commit has no ACKs. Tree-SHA512: 26308ca2807ff954ace6308a42e490d61fe8e95ed92b3453233ec72a59a38d975cfb1cf6bdeda93d4c855e6994c593f05b6cc1d2e78bc4ab3d7bde84c02a8982
Fixes #1518