Update INSTALL.md to include NetBSD

[ghost]

install instructions on netbsd

[AdamISZ]

Can anybody else confirm that this works for them?

[AdamISZ]

So in the absence of other testers:

• Having read through the instructions, there is nothing that could be considered objectionable or needing further verification imo. If there's some detail missed, that's not a disaster. So I'm tempted to just say "merge". But, very minor questions:
• I notice you didn't include a Qt install, which is fine, does that need to be said? (or is it obvious that that can't be done on NetBSD?). You did add a note 'without virtualenv', though; is there a specific reason for removing the virtualenv element or, is it ,again, obvious why that's the choice here?

[bfiics]

Looks good and very important. But can you make the "installation" more cleaner somehow?

[AdamISZ]

Looks good and very important. But can you make the "installation" more cleaner somehow?

For most users, the /.install.sh command explained in the README is the correct, and much simpler installation process, than what is in INSTALL.md (written there to help people in situations which are not so common).

Did you test this on netbsd @bfiics ? As per above, I am waiting on that, even though I certainly trust this contributor, it seems wrong to merge any instructions unless it's confirmed independently.

[bfiics]

@AdamISZ
Sorry my bad, I didnt test it, but looked very legit. I just realized this PR is old. My opinion is to close this PR, but its your choice.

[kristapsk]

@bfiics Don't see the reason to close, just somebody needs to test this on NetBSD.

[hellodarkness]

I'm not a NetBSD user but I tried this in a VirtualBox VM on Windows. I followed the instructions exactly (including the same version of coincurve listed above).

I was getting SSL certificate errors when trying to download from Github. They were fixed with:

pkgin install mozilla-rootcerts-openssl

After that, I can confirm the instructions above work to build JoinMarket. I was able to run the wallet-tool, which created a joinmarket.cfg in the user directory as you would expect. I haven't gone as far as connecting to a node, but I can confirm the build ran without errors.

[AdamISZ]

@hellodarkness

Many thanks for the report.

I was getting SSL certificate errors when trying to download from Github.

Can I ask what was being downloaded at that point? Do you mean Joinmarket (i.e. this repository), or was it something that happened during the execution of ./install.sh?

[kristapsk]

I was getting SSL certificate errors when trying to download from Github. They were fixed with:

pkgin install mozilla-rootcerts-openssl

I assume this is something normally will be always installed, sounds like root certificates. Of course, any HTTPS download will fail without them.

[hellodarkness]

Can I ask what was being downloaded at that point? Do you mean Joinmarket (i.e. this repository), or was it something that happened during the execution of ./install.sh?

The error was just a general HTTPS thing, as @kristapsk says.

wget-ing coincurve threw an SSL error so I ran that with --no-check-certificates

Then git clone failed on the JoinMarket repo, so I looked up what needed to be installed to fix it.

I just mentioned the issue for completeness' sake. This was a completely fresh full install of NetBSD in an VirtualBox VM in Windows, and for some reason they were missing.

[hellodarkness]

Just to add... is coincurve still required? The "why not use Lightning-based onions" bit of this mentions the dependency was removed, so that step of the installation instructions may be redundant.

[kristapsk]

I would say we should just merge this. Will take forever to have more eyes on it. Better to have instructions with some minor issues than no instructions at all.

[AdamISZ]

I would say we should just merge this. Will take forever to have more eyes on it. Better to have instructions with some minor issues than no instructions at all.

You think? I always feel like for instructions on software which isn't part of this repo (including distros/OSes), it seems logical to get at least a second opinion before merging. But, I'm OK with you making the call.