Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Agora IRC in configuration defaults #1026

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

kristapsk
Copy link
Member

Up for discussion, of course. Historically it was disabled by default at one point, as it was unreliable back then. But, as I already mentioned in #997, haven't noticed any issues with it recently (for months).

@openoms
Copy link
Contributor

openoms commented Oct 1, 2021

ACK fb9f593

Tested successfully over Tor.
This is needed as hackint only shows a few orders now (users reporting on Telegram too).

An orderbook with hackint + agora:
http://526xpibebns6mehmmfqj5kpzl4shg4wa7sdwbnpsjqenfidbnn4m3lyd.onion

@AdamISZ
Copy link
Member

AdamISZ commented Oct 1, 2021

(Just for clarification, apparently there is confusion: we currently have hackint and darkscience, but agreed on having a third default, there is essentially no harm in it and there are reports that hackint is unreliable.)

(Additional commentary for those wishing to understand better: if any 1 out of n configured IRC servers is not even reachable (or channel not join-able), we allow the bot to finish its startup sequence after a 60 second timeout. If there are dropped connections, we can auto-switch even during a transaction negotiation, but it depends on details and certainly there are scenarios where communications might fail. This is one of a couple reasons I'm very motivated to continue work on #1000 as soon as I can find the time and would ask others to join me in that, or any other solution, of course).

@AdamISZ
Copy link
Member

AdamISZ commented Oct 1, 2021

tACK and merging.

@AdamISZ AdamISZ merged commit e93eef3 into JoinMarket-Org:master Oct 1, 2021
@kristapsk kristapsk deleted the reenable-agora branch October 2, 2021 00:34
kristapsk added a commit to kristapsk/raspibolt-extras that referenced this pull request Oct 24, 2021
It is re-enabled in JM by default now again
(JoinMarket-Org/joinmarket-clientserver#1026),
was reminded to me by the user in #11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants