Skip to content

Commit

Permalink
Merge #1490: CI: Disable venv cache and remove editable installs
Browse files Browse the repository at this point in the history
198117f CI: Remove editable installs (Kristaps Kaupe)
3641f1e Disable venv caching (Kristaps Kaupe)

Pull request description:

  See #1479 (comment). This seems to be at least increasing chances of CI to succeed. I commented out not removed venv cache part as a reminder that this is not what we want in a long term.

  `sed -i.bak` not just `sed -i` is to be compatible with both GNU (Linux) and macOS sed.

ACKs for top commit:
  AdamISZ:
    utACK 198117f

Tree-SHA512: 53c2135589be5e24df234e2d168d49a6d841769c4e4ec52227b7fb39c8c043400a9c402dea58fc28c6a1cc394fb580b32cda201f7289b6eb3bd33c8e70846822
  • Loading branch information
kristapsk committed May 9, 2023
2 parents a242967 + 198117f commit 64b76d9
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions .github/workflows/unittests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,19 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Cache venv
id: cache-venv
uses: actions/cache@v3
env:
cache-name: venv
with:
path: jmvenv
key: ${{ runner.os }}-${{ matrix.python-version }}-${{ env.cache-name }}-${{ hashFiles('requirements/*.txt', 'install.sh', '*/setup.py') }}
# - name: Cache venv
# id: cache-venv
# uses: actions/cache@v3
# env:
# cache-name: venv
# with:
# path: jmvenv
# key: ${{ runner.os }}-${{ matrix.python-version }}-${{ env.cache-name }}-${{ hashFiles('requirements/*.txt', 'install.sh', '*/setup.py') }}
- name: Setup joinmarket + virtualenv
if: steps.cache-venv.outputs.cache-hit != 'true'
# if: steps.cache-venv.outputs.cache-hit != 'true'
run: |
sed -i.bak 's/-e //g' requirements/base.txt
sed -i.bak 's/-e //g' requirements/gui.txt
./install.sh --develop --with-qt
./jmvenv/bin/python -m pip install --upgrade pip
./jmvenv/bin/pip install -r requirements/base.txt
Expand Down

0 comments on commit 64b76d9

Please sign in to comment.