refactor: used angular.isDefined() instead of typeof !== "undefined"

JohnnyTheTank · Feb 17, 2016 · 443a16a · 443a16a
1 parent 85478d1
commit 443a16a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/dist/angular-github-api-factory.js b/dist/angular-github-api-factory.js
@@ -1,6 +1,6 @@
 /**
     @name: angular-github-api-factory 
-    @version: 0.5.0 (06-01-2016) 
+    @version: 0.5.0 (17-02-2016) 
     @author: Jonathan Hornung 
     @url: https://github.com/JohnnyTheTank/angular-github-api-factory#readme 
     @license: MIT
@@ -76,7 +76,7 @@ angular.module("jtt_github", [])
         this.fillDataInObjectByList = function (_object, _params, _list) {
 
             angular.forEach(_list, function (value, key) {
-                if (typeof _params[value] !== "undefined") {
+                if (angular.isDefined(_params[value])) {
                     _object.object[value] = _params[value];
                 }
             });
@@ -92,7 +92,7 @@ angular.module("jtt_github", [])
                 url: "",
             };
 
-            if (typeof _params.per_page !== "undefined") {
+            if (angular.isDefined(_params.per_page)) {
                 githubSearchData.object.per_page = _params.per_page;
             }
 
@@ -141,7 +141,6 @@ angular.module("jtt_github", [])
                     githubSearchData.url = this.getApiBaseUrl() + "repos/" + _params.user + "/" + _params.repo + "/events";
                     break;
             }
-
             return githubSearchData;
         };
     });
diff --git a/dist/angular-github-api-factory.min.js b/dist/angular-github-api-factory.min.js
diff --git a/src/angular-github-api-factory.js b/src/angular-github-api-factory.js
@@ -69,7 +69,7 @@ angular.module("jtt_github", [])
         this.fillDataInObjectByList = function (_object, _params, _list) {
 
             angular.forEach(_list, function (value, key) {
-                if (typeof _params[value] !== "undefined") {
+                if (angular.isDefined(_params[value])) {
                     _object.object[value] = _params[value];
                 }
             });
@@ -85,7 +85,7 @@ angular.module("jtt_github", [])
                 url: "",
             };
 
-            if (typeof _params.per_page !== "undefined") {
+            if (angular.isDefined(_params.per_page)) {
                 githubSearchData.object.per_page = _params.per_page;
             }
 
@@ -134,7 +134,6 @@ angular.module("jtt_github", [])
                     githubSearchData.url = this.getApiBaseUrl() + "repos/" + _params.user + "/" + _params.repo + "/events";
                     break;
             }
-
             return githubSearchData;
         };
     });