Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON [panel and divider] #395

Closed
wants to merge 3 commits into from
Closed

Conversation

mattreim
Copy link
Contributor

@mattreim mattreim commented Oct 2, 2024

json

  1. Panel -> tab is now unnecessary
  2. Divider and header -> for better readability

@Jey-Cee
Copy link
Owner

Jey-Cee commented Oct 2, 2024

I am not happy with the second header. Yes it looks better, but header means new section which it isn't.

There is a technical reason why we should not do this in this way:
There are tools like screen reader they use this information for proper function.

The other reason is the EEA (European accessibility act) which says any digital interface has to be accessible for humans with disabilities and older ones. That means tools like screen readers must be able to read/interpret the interface.
Actual it is unclear if this has an impact on projects like ioBroker, but i think it is better to build our interface in a way that makes it also accessible for those people who have limitations and uses these tools.

@mattreim mattreim changed the title Update JSON [panel, divider and header] Update JSON [panel and divider] Oct 2, 2024
@mattreim
Copy link
Contributor Author

mattreim commented Oct 2, 2024

Less is more...

JSON

@Jey-Cee
Copy link
Owner

Jey-Cee commented Oct 2, 2024

What do you think about this?
grafik
grafik

@mattreim
Copy link
Contributor Author

mattreim commented Oct 2, 2024

I think it's good except for the tab ;)

@mattreim
Copy link
Contributor Author

mattreim commented Oct 2, 2024

I think these things are better too.

Port -> min ->1
Websocket Port -> min ->1
_header1 -> "newLine": true, (just to be safe)

And I removed this sentence in WEBLATE because it is no longer a pop-up.

"Instruction": ...Leave this message open.

@mattreim
Copy link
Contributor Author

mattreim commented Oct 2, 2024

I think the innovations are very good.

@Jey-Cee
Copy link
Owner

Jey-Cee commented Oct 3, 2024

I have applied the changes and released 1.6.1

@Jey-Cee Jey-Cee closed this Oct 3, 2024
@mattreim mattreim deleted the JSON branch October 3, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants