Support Async termination #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iliya-usov
force-pushed
the
AsyncTermination
branch
3 times, most recently
from
5a1eda8
to
c0a88be
Compare
Iliya-usov
force-pushed
the
AsyncTermination
branch
from
c0a88be
to
7dd971d
Compare
ForNeVeR
approved these changes
Mar 18, 2021
| if (task.IsCompleted) | ||
| return task; | ||
|
|
||
| var timer = new System.Timers.Timer(timeoutMs) {AutoReset = false}; |
There was a problem hiding this comment.
Wouldn't it be better to do this via Task.Delay(timeoutMs).ContinueWith(_ => myTcs.TrySetResult(false)), or something alike?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.