Skip to content

Commit

Permalink
Include sources in kotlin-osgi-bundle
Browse files Browse the repository at this point in the history
With this change, we include the sources of all dependencies of
`kotlin-osgi-bundle` in its source bundle.
This gives users of this library a better IDE and debugging experience
providing documentation and allows users to debug in the stdlib.

This implementation works very similarly on how the class files of the
dependencies are merged. This also means that currently conflicts are
not handled at all.
This is probably fine, since there should actually be no duplicates.

^KT-28492 Fixed
  • Loading branch information
beatbrot committed Sep 27, 2024
1 parent 9f97f04 commit 987f423
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions libraries/tools/kotlin-osgi-bundle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,19 @@
<excludes>**/MANIFEST.MF</excludes>
</configuration>
</execution>
<execution>
<id>unpack-sources</id>
<phase>generate-sources</phase>
<goals>
<goal>unpack-dependencies</goal>
</goals>
<configuration>
<classifier>sources</classifier>
<includeScope>compile</includeScope>
<includeGroupIds>${project.parent.groupId}</includeGroupIds>
<outputDirectory>${project.build.directory}/sources</outputDirectory>
</configuration>
</execution>
</executions>
</plugin>

Expand Down Expand Up @@ -92,9 +105,8 @@
<goal>jar</goal>
</goals>
<configuration>
<skipIfEmpty>false</skipIfEmpty>
<classifier>sources</classifier>
<classesDirectory>${basedir}/sources</classesDirectory>
<classesDirectory>${project.build.directory}/sources</classesDirectory>
</configuration>
</execution>
</executions>
Expand Down

0 comments on commit 987f423

Please sign in to comment.