-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote compilers' filepaths with "" for Windows #406
Quote compilers' filepaths with "" for Windows #406
Conversation
I created tests using ChatGPT on my Windows machine for a Java program and can confirm that they do run now. However, it seems that I am struggling to run tests for Kotlin. The test generated by the LLM results in a failure with the exception message "file." when running from the TestSpark tool window. But when copying the same tests into a test file, the test runs just fine; see the attached screenshot. If this is caused by a separate issue, it could be addressed in another PR. |
Can you please check if classfiles are saved properly for Kotlin compilation on Windows? This potentially can cause the issue from #407 and such an error like Expected behavior for it: classfile is stored in the same location as the source file. In other fords |
@Hello-zoka
My path to kotlinc (according to TestSpark) is following |
So... I debugged the problem a bit more and found out that the reason I get The new command will look something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does solve the issue or running tests from TestSpark's tool window for Java programs. However, there are still problems for Kotlin if you do not have Java in your PATH variable. I suppose this will be fixed in another PR.
Thank you, everyone, for the thorough discussion. If @Hello-zoka has tried it on the Mac and it works fine, we can merge this PR. |
Yeah, that works for me since nothing has changed for Mac. As I was able to verify through googling, also should work for Windows |
Description of changes made
Closes #402
Please write if you have anything to add
I still treat non-Windows systems separately: I used a single quote
' '
to escape compilers' filepaths for Unix because bash treats a single quote as plain text, the double quote may contain command calls.I tested both on Windows and Mac; the error from the issue got resolved. For Windows though, there is another one #407, which is not covered here.