Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to change composer.json filename #85

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zlodes
Copy link
Contributor

@zlodes zlodes commented Oct 8, 2019

We are using composer merge plugin and store local repositories and dependencies (for package development) into composer.dev.json.

This patch will add ability to change the composer.json filename via config.

@Jeroen-G
Copy link
Owner

Jeroen-G commented Oct 8, 2019

Cool, thanks!
Are you able to write a test for using this with/without a custom composer file?

@zlodes
Copy link
Contributor Author

zlodes commented Oct 8, 2019

Yeap, I can. I'll do it tomorrow.

@zlodes zlodes force-pushed the dev-composer-json-filename branch from f46f122 to cc055d2 Compare October 10, 2019 14:48
@zlodes zlodes force-pushed the dev-composer-json-filename branch from cc055d2 to da12679 Compare October 10, 2019 14:48
@zlodes
Copy link
Contributor Author

zlodes commented Oct 14, 2019

@Jeroen-G added tests

@zlodes
Copy link
Contributor Author

zlodes commented Oct 25, 2019

🌚

@Jeroen-G
Copy link
Owner

Ok, so help me here: why should one want to change the filename of composer.json to somethingElse.json?

@zlodes
Copy link
Contributor Author

zlodes commented Nov 3, 2019

Ok, so help me here: why should one want to change the filename of composer.json to somethingElse.json?

I wrote about this in the first message: it will be useful with merge plugin by wikimedia: https://github.com/wikimedia/composer-merge-plugin.

Sometimes we doesn't want to foul up our composer.json file. I use composer.dev.json (vcs-ignored) whom will be merged with original composer.json via merge plugin.

@Jeroen-G Jeroen-G added the postponed Needs more thinking and elaboration. label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postponed Needs more thinking and elaboration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants