Various ALERT updates #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have been AHDC::adc (since corresponding HitReader also uses this bank), it was AHDC::tdc.
(and stop changing wire number internally to start from zero) (this requires removing a manual +1 offset for wire number in a perl script in GEMC)
Iss272 alert indexing
get latest changes
Fix of a merge error after commit f10c09e
PreCluster pairing routine in AHDC ClusterFinder
…r-layer list of hits in AHDC PreCluster Modified the hardcoded lookup superlayer indices to obtain the geometry parameters to calculate x, y.
Modifications for debugging/validation of index convention change.
Update time calculations in ModeAHDC.java
Add a new mode of extraction for AHDC
…end points; * Adjusted the initial covariance matrix parameters; * Added methods n KFitter and Hit to set better measurement and noise matrices for hits; *** For debugging purposes only: *** * Added a method to reconstruct that tracks gathering all hits, and sets the track parameters as follows: px = 150.0*sin(atan2(y_w0, x_w0)), py = 150.0*cos(atan2(y_w0, x_w0)) set with x_w0, y_w0 origin of first wire hit; x, y, z = 0, pz = 0; => only good for MC with no background; * commented out the track finding method and using the method described above.
…ector_simple" for Hit, and "H_simple", "h_simple" for KFitter to return the preexisting matrix emasurements; new matrix measurements have been implemented in the methods "getMeasurementNoise", "getVector", "H" and "h". Added new memebers "adc" and "phi" for the hit for measured ADC and wire phi position at z = 0 respectively.
Getting changes from Michael
…tem, one to minimize track distance. Added functions to calculate phi for hit as a function of z and to calculate the hit "sign" i.e. the side of the wire the track passes.
…ers all hits to make a track candidate and uncommented the track finding code.
Kalman Filter fixes: constants and parameters
fix bad merge conflict
…r to not loop 12 more times than needed
Actually use the new waveform conversion approach for AHDC
Use DeepJavaLibrary to load a PyTorch model. Create a new bank AHDC_AI::Prediction.
This reverts commit 3420bb9.
Revert "leave internal indexing at zero, output at 1"
Add AI for ALERT trackfinding
|
Supercedes #378 |
auto-merge was automatically disabled
January 2, 2025 22:08
Rebase failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #378