implemented a new service to be used in DCALIGN cooking, #380
+193
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormation for AI training and validation
baltzell
requested changes
Dec 5, 2024
raffaelladevita
requested changes
Dec 5, 2024
| @@ -1,4 +1,23 @@ | |||
| [ | |||
| { | |||
There was a problem hiding this comment.
Can the new bank be added at the bottom of the file, so that they are ordered by item?
| @@ -51,6 +51,8 @@ services: | |||
| name: RICH | |||
| - class: org.jlab.service.rtpc.RTPCEngine | |||
| name: RTPC | |||
| - class: org.jlab.service.mltn.MLDCEngine | |||
There was a problem hiding this comment.
dcalign.yaml is really only used for straight tracks/alignment runs. The new service should be added to data-ai.yaml or data-cv.yaml or data-aicv.yaml.
| de.appendBank(output);*/ | ||
| } | ||
|
|
||
| if(de.hasBank("TimeBasedTrkg::AITracks")&&de.hasBank("TimeBasedTrkg::AIClusters")){ |
There was a problem hiding this comment.
Note that the banks with the AI prefix are created only when data-aicv.yaml is used. When data-ai.yaml is used, the tracking banks have the TB prefix even if AI tracking is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New banks in the output should help with ai training and validation