Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in uRwell strip factory causing R2 strips not being created… #188

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

raffaelladevita
Copy link
Collaborator

… when the 2 region configuration was selected, changed uRWell service to always load the 2 region configuration
Closes #187

… when the 2 region configuration was selected, changed uRWell service to always load the 2 region configuration
@raffaelladevita raffaelladevita added the bug Something isn't working label Feb 12, 2024
baltzell
baltzell previously approved these changes Feb 12, 2024
tongtongcao
tongtongcao previously approved these changes Feb 12, 2024
Copy link
Collaborator

@tongtongcao tongtongcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test the updates by samples with one and two uRWells, seperately. It works.

@tongtongcao tongtongcao self-requested a review February 16, 2024 16:05
@tongtongcao
Copy link
Collaborator

… when the 2 region configuration was selected, changed uRWell service to always load the 2 region configuration Closes #187

@raffaelladevita raffaelladevita dismissed stale reviews from tongtongcao and baltzell via af3abae February 16, 2024 19:49
Copy link
Collaborator

@tongtongcao tongtongcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all right.

@baltzell baltzell merged commit ff85fe9 into development Feb 23, 2024
67 checks passed
@baltzell baltzell deleted the iss187-urWellR2 branch February 23, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URWell strip factory doesn't create region 2 strips
3 participants