Cut release 2.3.1 #328
Merged
Cut release 2.3.1 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwbrei
force-pushed
the
nbrei_release_candidate
branch
from
3831cf6 to
6e7febb
Compare
This doesn't work with the current EICrecon implementation because EICrecon's JOmniFactory implementation has an m_app data member that shadows JMultifactory. Multifactory helpers don't need a JApplication pointer in practice because they delegate all their work to their Multifactory.
nathanwbrei
force-pushed
the
nbrei_release_candidate
branch
from
30a1efa to
91918cc
Compare
The JComponentManager runs JFactory::Init() for each factory in the set, simply so it can collect JParameters before processing. Sometimes Init() throws an exception (e.g. due to missing geometry). If the factory was never going to be called anyway, that exception shouldn't be thrown anyhow, and if the factory does gets called, the exception will be thrown then. So there's no harm in suppressing exceptions here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.