Make Send bound optional for AsyncTestContext #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncTestContext
was originally implemented by using#[async_trait::async_trait]
. Unfortunately this forces futures to beSend
which sometimes unfeasible.I've added a separate feature to the create
async_send
which is on by default. This way by default crate behaves identically to previous version. But if you disable this feature thenAsyncTestContext
will be created with#[async_trait::async_trait(?Send)]
which allows futures to be notSend
.I wasn't able to think about any other mechanism other than feature flag. It would be great if you come up with something and it won't be a breaking change.