Skip to content

Commit

Permalink
Add new scala versions.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jan Boerman committed Mar 19, 2024
1 parent 0858e7d commit d6fe034
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ public void add(SV scalaVersion) {
}
}

//TODO be more stricts about which version is consuming which other version?
//TODO e.g. 3.4.0 can consume 2.13.x and 3.[0123].x, but 3.3.x cannot consume 3.4.x.
private static boolean isCompatible(String one, String two) {
ScalaRelease release1 = ScalaRelease.fromScalaVersion(one);
ScalaRelease release2 = ScalaRelease.fromScalaVersion(two);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public enum ScalaVersion {
v2_13_10("2.13.10"),
v2_13_11("2.13.11"),
v2_13_12("2.13.12"),
v2_13_13("2.13.13"),

//3.0.x
v3_0_0("3.0.0"),
Expand All @@ -62,9 +63,14 @@ public enum ScalaVersion {
v3_2_1("3.2.1"),
v3_2_2("3.2.2"),

//3.3.x
//3.3.x (LTS)
v3_3_0("3.3.0"),
v3_3_1("3.3.1");
v3_3_1("3.3.1"),
v3_3_2("3.3.2", false),
v3_3_3("3.3.3"),

//3.4.0
v3_4_0("3.4.0");

//TODO include hashes of the jars! so that the loader can verify the integrity of the jars!

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
*
* @author Jannyboy11
*/
// TODO should ScalaLoader have a custom bootstrapper? probably yes, since we can use it to delegate plugin lifecyle events to scala plugins. Is that the only way to do it?
public final class ScalaLoader extends JavaPlugin implements IScalaLoader, Listener {

static {
Expand Down

0 comments on commit d6fe034

Please sign in to comment.