Fix code comments, formatting issues.

Jannyboy11 · Dec 25, 2024 · aa3e58e · aa3e58e
1 parent bb6a1fa
commit aa3e58e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/ScalaLoader-Common/src/main/java/xyz/janboerman/scalaloader/plugin/PluginScalaVersion.java b/ScalaLoader-Common/src/main/java/xyz/janboerman/scalaloader/plugin/PluginScalaVersion.java
@@ -33,8 +33,8 @@ public static void register() {
 
 
     private final String scalaVersion;
-    private final Map<String, String> urls;
-    private final Map<String, String> sha1Hashes;
+    private final Map<String, String> urls;         //uses keys such as the string constants above.
+    private final Map<String, String> sha1Hashes;   //uses same keys as urls.
 
     /**
      * @deprecated since Scala 3 there are more artifacts than just the scala standard library and the scala reflection library

diff --git a/...ader-Common/src/main/java/xyz/janboerman/scalaloader/plugin/description/ScalaVersion.java b/...ader-Common/src/main/java/xyz/janboerman/scalaloader/plugin/description/ScalaVersion.java
@@ -91,8 +91,6 @@ public enum ScalaVersion {
     v3_6_1("3.6.1", false),
     v3_6_2("3.6.2");
 
-    //TODO include hashes of the jars! so that the loader can verify the integrity of the jars!
-
     private static Map<String, ScalaVersion> byVersion = new HashMap<>();
     private static final ScalaVersion latest_2_13;
     static {

diff --git a/ScalaLoader-Common/src/main/java/xyz/janboerman/scalaloader/util/ScalaLoaderUtils.java b/ScalaLoader-Common/src/main/java/xyz/janboerman/scalaloader/util/ScalaLoaderUtils.java
@@ -158,8 +158,6 @@ public static void downloadFile(URL inputResourceLocation, File outputFile, Stri
     /** @deprecated Use {@linkplain #downloadFile(URL, File, String)} instead.*/
     @Deprecated
     public static void downloadFile(URL inputResourceLocation, File outputFile) throws IOException {
-        // TODO adjust call sites.
-
         ReadableByteChannel rbc = null;
         FileOutputStream fos = null;
         try {
@@ -172,7 +170,6 @@ public static void downloadFile(URL inputResourceLocation, File outputFile) thro
         }
     }
 
-
     private static void checkSha1Hash(File outputFile, String sha1hash) throws IOException {
         if (sha1hash == null || sha1hash.isEmpty()) return;
 

diff --git a/...er/src/main/java/xyz/janboerman/scalaloader/paper/plugin/description/ScalaDependency.java b/...er/src/main/java/xyz/janboerman/scalaloader/paper/plugin/description/ScalaDependency.java
@@ -20,7 +20,6 @@ public String getVersionString() {
     }
 
     public static record Custom(String scalaVersion, Map<String, String> urls, Map<String, String> sha1hashes) implements ScalaDependency {
-
         /** @deprecated Use canonical constructor instead. */
         @Deprecated
         Custom(String scalaVersion, Map<String, String> urls) {