Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load images from sub-folders #60

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jul 4, 2024

Description

Implement loading ocis images from the sub-directories.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: ✋ and 🤖

Screenshots (if appropriate):

image

## Slide With oCIS Image - sub

![webdriver_ill.jpg](./sub/inner/webdriver_ill.jpg)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)
  • Documentation only (no source changes)
  • Maintenance (e.g. dependency updates or tooling)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation updated

@saw-jan saw-jan self-assigned this Jul 4, 2024
@saw-jan saw-jan mentioned this pull request Jul 4, 2024
6 tasks
@saw-jan saw-jan marked this pull request as ready for review July 4, 2024 09:17
@saw-jan saw-jan requested review from grgprarup and S-Panta July 4, 2024 09:17
@S-Panta
Copy link
Contributor

S-Panta commented Jul 5, 2024

Works in my setup but it take some millisecond to render the image if there are more subfolder.

src/App.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@S-Panta S-Panta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Manually. LGTM

@saw-jan saw-jan force-pushed the feat/load-subfolder-image branch from 46abd85 to 4e66ec1 Compare July 9, 2024 11:12
@saw-jan saw-jan merged commit bff366c into main Jul 9, 2024
1 check passed
@saw-jan saw-jan deleted the feat/load-subfolder-image branch July 9, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] embed images
2 participants