Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: provide element ref to reveal #58

Merged
merged 1 commit into from
Jul 8, 2024
Merged

refactor: provide element ref to reveal #58

merged 1 commit into from
Jul 8, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jul 4, 2024

Description

Pass element ref to the Reveal. this makes the code testable.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)
  • Documentation only (no source changes)
  • Maintenance (e.g. dependency updates or tooling)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation updated

@saw-jan saw-jan self-assigned this Jul 4, 2024
@saw-jan saw-jan requested review from grgprarup and S-Panta July 4, 2024 04:17
@saw-jan saw-jan merged commit b68deb6 into main Jul 8, 2024
1 check passed
@saw-jan saw-jan deleted the refactor/pass-element-ref branch July 8, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Panta S-Panta S-Panta approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@saw-jan saw-jan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @S-Panta