Pwm #94
Open
Pwm #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for the contribution. It's not something I've really explored much as I haven't needed it myself, and it can be difficult keeping up with the limited functionality this module offers currently. There was a request for it back in #62 though - maybe there is more demand? I hope you won't mind if I leave this for a bit until I've chance to read up on how it all works a bit more. |
|
For me this implementation looks similar to the python implementation. There is some further explanation on how the pwm management on the raspberry pi kernel works. I would be glad to see this pull request merged 🎉. |
|
+1 for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for PWM signals.
It's a prerequisite to write the line: "dtoverlay=pwm-2chan" in the file /boot/config.txt to enable the PWM.
I tested it briefly in my Raspberry Pi 3 B, but if someone could do a deeper test, feel free to do that.
Any suggestion is welcome!