feat: Minimize focused window option for launcher #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeStanger
reviewed
Nov 10, 2024
JakeStanger
reviewed
Nov 10, 2024
JakeStanger
reviewed
Nov 10, 2024
JakeStanger
requested changes
Nov 10, 2024
|
Changes should be addressed now, thank you for taking a look! |
JakeStanger
reviewed
Nov 10, 2024
JakeStanger
force-pushed
the
minimize
branch
from
f2c2cdc to
64b953c
Compare
JakeStanger
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new config option
minimize_focusedto the launcher module, which when set to true will minimize the currently focused window if its icon is clicked. If there is more than a single window open of that particular application the normal focus behavior will occur.I haven't written much rust before, but hopefully it's relatively problem free!
Resolves #658