Workspaces module rewrite #748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeStanger
force-pushed
the
fix/workspaces
branch
3 times, most recently
from
0d6a36f to
7b53deb
Compare
|
No idea why the build is failing, seems GH have messed up their task runner |
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay! Fixes #705 Fixes an issue with moving favourite workspaces. Fixes an issue with workspace visible state being incorrect. Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
JakeStanger
force-pushed
the
fix/workspaces
branch
from
7b53deb to
2cd2d25
Compare
JakeStanger
commented
Dec 4, 2024
| let mut buttons = container | ||
| .children() | ||
| .into_iter() | ||
| .map(|child| (child.widget_name().to_string(), child)) |
There was a problem hiding this comment.
Will need updating to child.label() (see #799 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(workspaces): rewrite module to fix several small issues
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay!
Fixes #705
Fixes an issue with moving favourite workspaces.
Fixes an issue with workspace visible state being incorrect.
Fixes an issue where the
inactiveclass looked at hidden instead of closed favourites.